Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLUS30650] Mass Effect 2 Broken face rendering #7397

Closed
JohnHolmesII opened this issue Feb 5, 2020 · 6 comments · Fixed by #8502
Closed

[BLUS30650] Mass Effect 2 Broken face rendering #7397

JohnHolmesII opened this issue Feb 5, 2020 · 6 comments · Fixed by #8502
Assignees
@kd-11
Labels
Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver

Comments

@JohnHolmesII
Copy link
Contributor

When in the character creation menu at the beginning of the game, one is able to create a situation where the face of the character is completely blacked out. ME seems to use some alpha masking to cull different parts of the head (i.e. top of head vs face), and IFF one selects the darkest beard color possible (far right slider), the whole face turns black. It seems like the alpha mask that gets used is flipped to black. I think the beard at that darkness level is probably perfectly black as well, and they just abuse the alpha mask that they already have. This is mostly speculation on my part.

good face

bad face

Render docs of normal vs full black facial hair: link
@kd-11
Copy link
Contributor

kd-11 commented Feb 5, 2020

Looks like typical precision drift on a division-related opcode, usually one of RSQ/RCP/DIVSQ/DIVSS/NRM.

@kd-11 kd-11 self-assigned this Feb 5, 2020
@dulsan
Copy link

dulsan commented Feb 6, 2020

I thought Mass Defect Andromeda couldn't get any worse...

@RainbowCookie32
Copy link
Contributor

I thought Mass Defect Andromeda couldn't get any worse...

Please keep the conversation on topic, your feelings for Andromeda are irrelevant for this issue with ME2 on RPCS3 :D

@kd-11
Copy link
Contributor

kd-11 commented Jun 15, 2020

Retest, likely fixed.

@JohnHolmesII
Copy link
Contributor Author

Still b0rked
image

@kd-11 kd-11 added In Progress This issue is actively being investigated at the moment. RSX Bug labels Jun 23, 2020
@kd-11 kd-11 mentioned this issue Jun 25, 2020
Merged
@kd-11 kd-11 added Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver and removed Bug RSX labels Jun 25, 2020
@sampletext32
Copy link
Contributor

Would you kindly remove "In Progress" label?

@AniLeo AniLeo removed the In Progress This issue is actively being investigated at the moment. label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kd-11 kd-11

Labels
Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rsx: Force flushing of NaN/INF to zero for all GPU vendors kd-11/rpcs3
6 participants
@JohnHolmesII @AniLeo @dulsan @kd-11 @RainbowCookie32 @sampletext32