Provide a custom diagnostic for conformance to NSObjectProtocol #28591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift classes cannot meaningfully conform to NSObjectProtocol. Inheriting from NSObject is the appropriate fix, so suggest that. Fixes rdar://problem/32543753.
|
@swift-ci please smoke test |
slavapestov
reviewed
Dec 5, 2019
hborla
approved these changes
Dec 5, 2019
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
beccadax
approved these changes
Dec 5, 2019
| // One cannot meaningfully declare conformance to the NSObject protocol | ||
| // in Swift. Suggest inheritance from NSObject instead. | ||
| if (isNSObjectProtocol(Proto)) { | ||
| if (T->getClassOrBoundGenericClass()) { |
There was a problem hiding this comment.
I'm not familiar with the surrounding code—does this call return the same class you dyn_cast<ClassDecl>() to get later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift classes cannot meaningfully conform to NSObjectProtocol.
Inheriting from NSObject is the appropriate fix, so suggest that.
Fixes rdar://problem/32543753.
The diagnostic now looks like this: