Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom S3 endpoints such as MinIO #34

Merged
merged 1 commit into from Jun 28, 2020

Conversation

harshavardhana
Copy link
Contributor

Tested with https://play.min.io

{
  "version": 1,
  "accesses": [
    {
      "user": "test",
      "pass": "test",
      "fs": "s3",
      "params": {
        "endpoint": "https://play.min.io",
        "region": "us-east-1",
        "bucket": "testbucket",
        "access_key_id": "Q3AM3UQ867SPQQA43P2F",
        "secret_access_key": "zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG",
        "path_style": "true"
      }
    }
  ],
  "passive_transfer_port_range": {
    "start": 2122,
    "end": 2130
  }
}

Tested with https://play.min.io

```
{
  "version": 1,
  "accesses": [
    {
      "user": "test",
      "pass": "test",
      "fs": "s3",
      "params": {
        "endpoint": "https://play.min.io",
        "region": "us-east-1",
        "bucket": "testbucket",
        "access_key_id": "Q3AM3UQ867SPQQA43P2F",
        "secret_access_key": "zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG",
        "path_style": "true"
      }
    }
  ],
  "passive_transfer_port_range": {
    "start": 2122,
    "end": 2130
  }
}
```
@harshavardhana
Copy link
Contributor Author

// cc @fclairamb

Copy link
Owner

@fclairamb fclairamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !

README.md Show resolved Hide resolved
@probot-auto-merge probot-auto-merge bot merged commit 8bb93e0 into fclairamb:master Jun 28, 2020
@harshavardhana harshavardhana deleted the custom branch June 29, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants