Avoiding a hard coded class name in a static calls

grikdotnet · Dec 8, 2020 · 149a910 · 149a910
1 parent c9a82b3
commit 149a910
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/acme-image/src/ImageService.php b/packages/acme-image/src/ImageService.php
@@ -48,4 +48,12 @@ public function doFoo(): mixed
         return $this->imageLib->foo();
     }
 
+    /**
+     * Example of adding the static method to the public API
+     * @return int
+     */
+    public static function answerUltimateQuestion(): int
+    {
+        return Image::answerUltimateQuestion();
+    }
 }
diff --git a/src/ImageResizeController.php b/src/ImageResizeController.php
@@ -14,7 +14,8 @@ public function __construct(public ImageInterface $image)
 
     public function action(?string $id)
     {
-        $answer = Acme\Image\lib\Image::answerUltimateQuestion();
+        //now the code is not bound to the Acme\Image\lib\Image class
+        $answer = $this->image::answerUltimateQuestion();
         $this->image->load($id);
     }
 }