Remove kubectl run generators #87077

soltysh · 2020-01-10T11:35:52Z

What type of PR is this?
/kind api-change
/kind cleanup
/kind deprecation
/priority backlog
/sig cli

What this PR does / why we need it:
Over a year ago we've deprecated all the generators from under kubectl run command except for the one responsible for generating a pod (see #68132).
This PR removes all the generators and deprecates all the flags towards the goal to make kubectl run simpler.

Special notes for your reviewer:
/assign @liggitt @seans3 @pwittrock

Does this PR introduce a user-facing change?:

Remove all the generators from kubectl run. It will now only create pods. Additionally, deprecates all the flags that are not relevant anymore.

/cc @kubernetes/sig-cli-api-reviews @kubernetes/sig-cli-pr-reviews

soltysh · 2020-01-10T11:41:33Z

/hold
for visibility

soltysh · 2020-01-10T11:50:54Z

/sig architecture
@kubernetes/sig-architecture-api-reviews since this is dropping a few of conformance tests

liggitt · 2020-01-10T14:17:46Z

test/e2e/kubectl/kubectl.go

-			Testname: Kubectl, run deployment
-			Description: Command ‘kubectl run’ MUST create a deployment, with --generator=deployment, when a image name is specified in the run command. After the run command there SHOULD be a deployment that should exist with one container running the specified image. Also there SHOULD be a Pod that is controlled by this deployment, with a container running the specified image.
-		*/
-		framework.ConformanceIt("should create a deployment from an image ", func() {


I'm surprised we had a conformance test using deprecated function... that shouldn't really have happened

yeah, my bad I didn't catch it earlier 😞

soltysh · 2020-01-10T20:28:16Z

/retest

sftim · 2020-01-11T17:13:37Z

Does this need an issue to remove / revise documentation about generators from the website?
(there might be one already)

sftim · 2020-01-11T17:14:24Z

Thinking about this, any website page that recommends using kubectl run will need to change. There might be some left.

soltysh · 2020-01-14T08:38:03Z

Does this need an issue to remove / revise documentation about generators from the website?
(there might be one already)

Yes, docs pr will follow.

In 1.18 the "run" command has effectively been removed and can no longer generate deployments as before. We now have to include large snippets of YAML in documentation. kubernetes/kubernetes#87077 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

caruccio · 2020-05-13T07:42:13Z

You guys are lucky this is not a Linus Torvalds' project.

NinjaPanda91 · 2020-05-13T14:18:22Z

Can we revert this PR ?
--port, --replicas flags and a bunch of flags are missing and I'm studying for CKA exam and i just found out it uses 1.18.

We can raise this back once I'm done with the exam.

sftim · 2020-05-13T16:45:32Z

To be clear, the deprecation occurred in #68132 based on SIG CLI's consensus-based decision making.
If you'd like to enhance kubectl create, or to suggest enhancements, I feel that those suggestions are much more likely to be accepted.

soltysh · 2020-05-14T16:37:30Z

#91113 should solve the issue @alexellis hope this helps your case 😺

alexellis · 2020-05-14T17:19:56Z

Nice to have port back, what about the other key flags?

sftim · 2020-05-14T17:32:50Z

To suggest an enhancement for kubectl, you can visit https://github.com/kubernetes/kubectl/issues/new (and I hope that people will make these suggestions)

supirman · 2020-05-16T17:57:35Z

Can we revert this PR ?
--port, --replicas flags and a bunch of flags are missing and I'm studying for CKA exam and i just found out it uses 1.18.

We can raise this back once I'm done with the exam.

I was taking some Qwiklabs labs, some of kubertes lab rely on kubectl run. It seem that kubectl in Google Cloud Shell got update recently and the lab not updated to this issue.

For the workaround, you can just use the old version where kubectl run still working in old ways.

Remove kubectl run generators Kubernetes-commit: dba8d60

tm1810 · 2020-08-29T12:46:38Z

kubectl run for deployments is being missed, can we get the features back in create please, this will make a lot of difference

armujahid · 2020-08-29T12:54:10Z

@tm1810 you can check kubernetes/kubectl#898

removed in PR 87077: kubernetes/kubernetes#87077

removed in kubernetes/kubernetes#87077

k8s-ci-robot assigned liggitt Jan 10, 2020

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 10, 2020

k8s-ci-robot assigned pwittrock and seans3 Jan 10, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020

soltysh force-pushed the remove_run_generators branch from 0d480d2 to caee7ab Compare January 10, 2020 11:50

k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2020

liggitt reviewed Jan 10, 2020

View reviewed changes

soltysh force-pushed the remove_run_generators branch 2 times, most recently from dbc8c0a to e1da66b Compare January 10, 2020 17:33

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020

soltysh mentioned this pull request May 14, 2020

Refactor create deployment and add --port flag #91113

Merged

supirman mentioned this pull request May 16, 2020

kubectl run to create deployment has been deprecated GoogleCloudPlatform/gke-logging-sinks-demo#39

Closed

lucaviolanti mentioned this pull request May 21, 2020

Use new Kubernetes API for creating deployments GoogleCloudPlatform/gke-logging-sinks-demo#40

Merged

zhouya0 mentioned this pull request May 29, 2020

Support kubectl create deployment with replicas #91562

Merged

github-actions bot mentioned this pull request Jun 2, 2020

Week Ending May 31, 2020 dev-obs/actus#165

Open

h3z mentioned this pull request Jun 29, 2020

kubectl run 不会再创建deployment了。 caicloud/kube-ladder#35

Closed

bbbmj mentioned this pull request Jun 30, 2020

docs(*): update kubectl run due to generators has removed caicloud/kube-ladder#37

Merged

zhouya0 mentioned this pull request Jul 15, 2020

Remove generators from kubectl commands #93100

Closed

14 tasks

Xercoy mentioned this pull request Jul 20, 2020

kubectl: add env option to deployment creation #93269

Closed

wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020

Merge pull request kubernetes#87077 from soltysh/remove_run_generators

cadada9

Remove kubectl run generators Kubernetes-commit: dba8d60

armujahid mentioned this pull request Jul 28, 2020

Enhance kubectl create (Add useful flags from kubectl run e.g. replicas, labels, requests, limits, env, port etc.) kubernetes/kubectl#898

Closed

dedelala mentioned this pull request Aug 25, 2020

update delete command to delete deployment DevOps-Represent/from-docker-to-kubernetes#7

Closed

cgchinmay mentioned this pull request Jun 22, 2021

Fix missing tutum/curl image aws/aws-app-mesh-examples#426

Closed

gohmc mentioned this pull request Aug 22, 2021

Not able to run load eksctl-io/eksctl#4117

Closed

chr2sn0 added a commit to chr2sn0/eks-workshop that referenced this pull request Oct 21, 2021

remove unknown flag '--generator'

745a0e4

removed in PR 87077: kubernetes/kubernetes#87077

chr2sn0 mentioned this pull request Oct 21, 2021

remove unknown flag '--generator' aws-samples/eks-workshop#1282

Closed

jritsema added a commit to jritsema/eks-workshop that referenced this pull request Dec 10, 2021

removes deprecated --generator flag

1cc4197

removed in kubernetes/kubernetes#87077

jritsema mentioned this pull request Dec 10, 2021

removes deprecated --generator flag aws-samples/eks-workshop#1303

Closed

gl-johnson mentioned this pull request Nov 9, 2022

Remove --generator tag cyberark/conjur-oss-suite-release#255

Merged

13 tasks

Rellum mentioned this pull request Dec 26, 2022

kubetctl errors on "replicas" flag of "run" subcommand tpryan/whack_a_pod#17

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove kubectl run generators #87077

Remove kubectl run generators #87077

soltysh commented Jan 10, 2020

soltysh commented Jan 10, 2020

soltysh commented Jan 10, 2020

liggitt Jan 10, 2020

soltysh Jan 10, 2020

soltysh commented Jan 10, 2020

sftim commented Jan 11, 2020

sftim commented Jan 11, 2020

soltysh commented Jan 14, 2020

caruccio commented May 13, 2020

NinjaPanda91 commented May 13, 2020

sftim commented May 13, 2020

soltysh commented May 14, 2020

alexellis commented May 14, 2020

sftim commented May 14, 2020

supirman commented May 16, 2020

tm1810 commented Aug 29, 2020

armujahid commented Aug 29, 2020

Remove kubectl run generators #87077

Remove kubectl run generators #87077

Conversation

soltysh commented Jan 10, 2020

soltysh commented Jan 10, 2020

soltysh commented Jan 10, 2020

liggitt Jan 10, 2020

Choose a reason for hiding this comment

soltysh Jan 10, 2020

Choose a reason for hiding this comment

soltysh commented Jan 10, 2020

sftim commented Jan 11, 2020

sftim commented Jan 11, 2020

soltysh commented Jan 14, 2020

caruccio commented May 13, 2020

NinjaPanda91 commented May 13, 2020

sftim commented May 13, 2020

soltysh commented May 14, 2020

alexellis commented May 14, 2020

sftim commented May 14, 2020

supirman commented May 16, 2020

tm1810 commented Aug 29, 2020

armujahid commented Aug 29, 2020