create scheduling_decision metrics #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vllry
reviewed
Mar 31, 2020
yangkev
force-pushed
the
yangkev-test-toolate-patch
branch
from
81ea72b
to
ad3088c
Compare
yangkev
force-pushed
the
yangkev-cronmetrics-schedulingdecision
branch
from
cf28a35
to
163f7b1
Compare
|
/lgtm |
yangkev
force-pushed
the
yangkev-test-toolate-patch
branch
from
ad3088c
to
4928a20
Compare
This commit introduces 2 new metrics: `scheduling_decision_invoke` is a counter per CronJob, per Namespace, that is incremented when the cronjob_controller decides to invoke a CronJob. `scheduling_decision_skip` is a counter per CronJob, per Namespace, that is incremented when the cronjob_controller sees that a CronJob has unmet schedule times, but chooses to still skip invoking the CronJob. This can happen because: 1. the controller missed the deadline to invoke the CronJob 2. ConcurrencyPolicy is Forbid, and a previous job is still running 3. ConcurrencyPolicy is Replace, and there's an error in trying to replace the currently running job (such as failed deletion) 4. The controller fails to instantiate a Job spec from the CronJob template Note: Kubernetes 1.14 does not include k8s.io/component-base/metrics. When porting this to 1.16, we'll need to convert to using k8s.io/component-base/metrics
These reasons are: 1. ConcurrencyPolicy would be violated 2. Scheduling deadline was missed 3. General Kubernetes errors
yangkev
force-pushed
the
yangkev-cronmetrics-schedulingdecision
branch
from
014c75e
to
2dc7fdd
Compare
yangkev
changed the base branch from
yangkev-test-toolate-patch
to
release-1.14.10-lyft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces 2 new metrics:
scheduling_decision_invokeis a counter per CronJob, per Namespace,that is incremented when the cronjob_controller decides to invoke a
CronJob.
scheduling_decision_skipis a counter per CronJob, per Namespace, thatis incremented when the cronjob_controller sees that a CronJob has unmet
schedule times, but chooses to still skip invoking the CronJob. This can
happen because:
replace the currently running job (such as failed deletion)
template
Note: Kubernetes 1.14 does not include k8s.io/component-base/metrics.
When porting this to 1.16, we'll need to convert to using
k8s.io/component-base/metrics