add Job scheduled start time annotation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an annotation to Jobs created by CronJobs that annotates them with "scheduled-start-time", which is the time that the CronJob is expected to invoke a Job. More specifically, if a CronJob is expected to run at 12:00:00, then this annotation is 12:00:00. Having this annotation is helpful for measuring start delay - the time between when a Cron is expected to run, and when it actually does.
vllry
reviewed
Apr 9, 2020
|
👍 assuming you've thought through the time formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an annotation to Jobs created by CronJobs that annotates
them with "scheduled-start-time", which is the time that the CronJob is
expected to invoke a Job.
More specifically, if a CronJob is expected to run at 12:00:00, then
this annotation is 12:00:00.
Having this annotation is helpful for measuring start delay - the time
between when a Cron is expected to run, and when it actually does.