Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item_image_button[]: button too small #7852

Open
p-ouellette opened this issue Nov 10, 2018 · 3 comments
Open

item_image_button[]: button too small #7852

p-ouellette opened this issue Nov 10, 2018 · 3 comments
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Low priority

Comments

@p-ouellette
Copy link
Contributor

p-ouellette commented Nov 10, 2018

Issue type
  • Bug report
Minetest version
5.0.0-dev-57a2f3e4
Summary

The button is too small resulting in the image exceeding its borders. Button should be the same size as inventory slots. See example below (using width and height of 1).

2018-11-09-231328_swaygrab

@sfan5
Copy link
Member

sfan5 commented Dec 27, 2020

I saw no indication that the changes I made were relevant to this bug, please retest.

@rubenwardy
Copy link
Member

I was going by

getHeight() / 16 is the cause of #7852. sweet.

@p-ouellette
Copy link
Contributor Author

Last time I looked at this I came to the conclusion that it's just the way Irrlicht draws the buttons. The image is exactly the size of the button so it overlaps the border. I used a 2px padding to make it look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Low priority
Projects
None yet
Development

No branches or pull requests

4 participants