Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core #535

Closed
matthiasjost opened this issue Sep 21, 2015 · 18 comments
Closed

.NET Core #535

matthiasjost opened this issue Sep 21, 2015 · 18 comments

Comments

@matthiasjost
Copy link

Is the .NET Core migration already on the roadmap?

@khellang
Copy link
Member

@matthiasjost It's already sitting on the dev-v2 branch 😄 I'm not sure what @nblumhardt has in mind when it comes to shipping it, though.

@matthiasjost
Copy link
Author

@khellang OK cool. I am still waiting for other libraries to be migrated. It looks like I need to wait a bit. The current version is ASP.NET 6 Beta 7. I guess it would be nice to have a "pre-release" package soon. I do not know when the release is expected.

@merbla
Copy link
Contributor

merbla commented Sep 21, 2015

@matthiasjost if you are looking at ASP.NET, have you checked out the Serilog repo/package that will fit in with Microsoft.Framework.Logging

@matthiasjost
Copy link
Author

That looks very interesting. Saw that Framework.Logging once. Probably very interesting for me. Thank you @merbla.

@merbla
Copy link
Contributor

merbla commented Oct 21, 2015

@matthiasjost an updated set of packages are available. Can this issue be closed?

@birarich
Copy link

I closed the issue...

But still we have to wait for serilog to run on dnx core 5.o?
On Oct 21, 2015 4:16 PM, "Matthew Erbs" notifications@github.com wrote:

@matthiasjost https://github.com/MatthiasJost an updated set of packages
https://www.nuget.org/packages/Serilog.Framework.Logging/ are
available. Can this issue be closed?


Reply to this email directly or view it on GitHub
#535 (comment).

@nblumhardt
Copy link
Member

@birarich Serilog already runs on .NET Core 5.0 - just install the Serilog package and you're good to go!

Its the (externally-shipped) sinks that need updating - the dev-v2 branch is working towards providing all the APIs that the sinks use on all platforms that support them, so you will likely need to recompile any sinks you need from source.

Notwithstanding any major changes from .NET/ASP.NET (!!!) it is probably time for us to get the pre-release v2 package tidied up and pushed to NuGet so the sinks can start to be re-targeted too. Let's leave this issue open as a way to track it:

  • PeriodicBatchingSink for .NET Core (needs an issue#)
  • Port built-in sinks File, RollingFile, Trace, etc. (done already by the amazing @khellang)
  • ILogger generic overloads and public Logger abstract base class with template method for implementors
  • Re-enable ignored tests
  • Target dotnet
  • Reenable the old performance/smoke tests
  • Adding an empty Serilog.FullNetFx.dll to the NET45 package that typeforwards PeriodicBatchingSink to Serilog.dll, so that existing sinks can be used with v2 (edit: need to forward LogContext as well)
  • Port LogContext to .NET Core (AsyncLocal<>?)
  • Resolve split identity problems - ideally existing code dependent on ILogger will still run on CLR (requires strong name) but SN is a second-class citizen on CoreCLR
  • Publish some formal compatibility info
  • Check/finalize v2 prerelease build numbering
  • Publish from AppVeyor

Anything else?

@birarich
Copy link

When I use serilog to write log into file it gives me error saying u cannot
write in file... as file method is obsolute.....
On Oct 21, 2015 4:54 PM, "Nicholas Blumhardt" notifications@github.com
wrote:

@birarich https://github.com/birarich Serilog already runs on .NET Core
5.0 - just install the Serilog package and you're good to go!

Its the (externally-shipped) sinks that need updating - the dev-v2 branch
is working towards providing all the APIs that the sinks use on all
platforms that support them, so you will likely need to recompile any sinks
you need from source.

Notwithstanding any major changes from .NET/ASP.NET (!!!) it is probably
time for us to get the pre-release v2 package tidied up and pushed to NuGet
so the sinks can start to be re-targeted too. Let's leave this issue open
as a way to track it:

  • PeriodicBatchingSink for .NET Core (needs an issue#)
  • ILogger generic overloads and public Logger abstract base class with
    template method for implementors
  • Check/finalize v2 prerelease build numbering
  • Publish from AppVeyor

Anything else?


Reply to this email directly or view it on GitHub
#535 (comment).

@nblumhardt
Copy link
Member

Thanks - these sinks are not yet supported on core. Added an item to the list above :-)

@birarich
Copy link

Yes thanks...

@matthiasjost
Copy link
Author

Thank you guys for your support.

@npnelson
Copy link

@nblumhardt I'm still trying to get my head around all the ramifications of ASPNET5, CoreCLR, UWP, etc, but I'm pretty sure that you want to replace all the DNXCore50/DNX451 references in project.json with DOTNET references (and any conditional compilation directives). Oren Novotny has a decent summary here (especially in the "Call to Action" section)

https://oren.codes/2015/07/29/targeting-net-core/

@nblumhardt
Copy link
Member

Hmm, was just in the process of creating a PR for this and pushed upstream (rather than to my fork) egads! Will try to get that sorted out now.

In good news, PeriodicBatchingSink, the tests, and an update to beta8 are done. We should be able to get this onto NuGet soon.

@khellang
Copy link
Member

khellang commented Nov 9, 2015

We should move over to the new netstandard TFM once it's supported.

See https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/standard-platform.md for details.

This issue is dependent on dotnet/corefx#4367 being completed.

@nblumhardt
Copy link
Member

Hi all, to keep things manageable I've split the remaining tasks into individual issues under the v2 label. Shortly I'll open a PR from the v2 branch to dev, and after that is merged we can start crossing these off.

@nblumhardt
Copy link
Member

@j2ghz
Copy link

j2ghz commented Jan 8, 2016

What's the status with Colored and Literate console sink? I was redirected here from serilog-archive/serilog-sinks-literate#4, this issue was split, but I don't see it anywhere.
EDIT: Colored is working, but there's another problem serilog/serilog-extensions-logging#24

@nblumhardt
Copy link
Member

Hi Jozef, the literate console sink is still on the TODO list, sorry. Shouldn't be too far away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants