Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Method in CglibAopProxy.fixedInterceptorMap instead of String returned from Method::toString #22258

Merged
merged 1 commit into from Feb 15, 2019

Conversation

stsypanov
Copy link
Contributor

There's no need to use Method's String representation as key in HashMap when we can use Method itself saving memory on map population and Map::get calls.

@stsypanov stsypanov changed the title Use Method in fixedInterceptorMap instead of String returned from Method::toString Use Method in CglibAopProxy.fixedInterceptorMap instead of String returned from Method::toString Jan 15, 2019
@jhoeller jhoeller self-assigned this Jan 21, 2019
@jhoeller jhoeller added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 21, 2019
@jhoeller jhoeller added the type: enhancement A general enhancement label Feb 15, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Feb 15, 2019
@jhoeller jhoeller merged commit e44d3da into spring-projects:master Feb 15, 2019
@stsypanov stsypanov deleted the simplify-cglib-aop-proxy branch February 19, 2019 11:28
@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants