Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist Class.getName() from String concatenation to dodge an issue related to profile pollution #25324

Closed
wants to merge 1 commit into from

Conversation

stsypanov
Copy link
Contributor

This is a continuation of PR #24153.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 27, 2020
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 27, 2020
@sbrannen sbrannen self-assigned this Jun 27, 2020
@sbrannen sbrannen added this to the 5.2.8 milestone Jun 27, 2020
@sbrannen sbrannen closed this in d08ce30 Jun 27, 2020
@sbrannen
Copy link
Member

This has been merged into 5.2.x and master.

Thanks

@stsypanov stsypanov deleted the hoist branch June 30, 2020 08:38
FelixFly pushed a commit to FelixFly/spring-framework that referenced this pull request Aug 16, 2020
This commit extracts a Class.getName() invocation from String
concatenation in AbstractMonitoringInterceptor to avoid an issue
related to profile pollution.

Closes spring-projectsgh-25324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants