Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message about duplicate keys #35

Merged
merged 1 commit into from Mar 28, 2021
Merged

Improve error message about duplicate keys #35

merged 1 commit into from Mar 28, 2021

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 28, 2021 •
edited

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues -

Before:

Duplicate key "age" in "F:/open-source/yiisoft/config/tests/configs/duplicate-keys/packages/test/a/params.php". Configs with the same key: "F:/open-source/yiisoft/config/tests/configs/duplicate-keys/params.php", "F:/open-source/yiisoft/config/tests/configs/duplicate-keys/packages/test/b/params.php".

After:

Duplicate key "age" in configs:
 - config/params.php
 - config/packages/test/a/params.php
 - config/packages/test/b/params.php

@vjik vjik added the status:code review The pull request needs review. label Mar 28, 2021
@vjik vjik requested a review from a team March 28, 2021 05:53
@samdark samdark merged commit 7e5d8c7 into master Mar 28, 2021
@samdark samdark deleted the messages branch March 28, 2021 22:07
@samdark
Copy link
Member

samdark commented Mar 28, 2021

Good one! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjik @samdark