Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sort to have two static constructors #70

Merged
merged 6 commits into from Jan 27, 2021

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Jan 26, 2021

Add Sort::any() and Sort::only() methods instead of constuctor

Q A
Breaks BC? ✔️
Fixed issues decide #67

todo:

@roxblnfk roxblnfk added the status:under development Someone is working on a pull request. label Jan 26, 2021
@samdark samdark added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Jan 27, 2021
@samdark samdark merged commit 8df2006 into yiisoft:master Jan 27, 2021
@samdark
Copy link
Member

samdark commented Jan 27, 2021

👍

@roxblnfk roxblnfk deleted the feature/sort-static-create-any-only branch January 28, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants