Add ErrorData and HeaderRenderer classes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devanych
commented
Feb 17, 2021
devanych
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues | #12, #13 |
samdark
requested changes
Feb 17, 2021
src/ErrorData.php
Outdated
| * | ||
| * @return ResponseInterface The response with error data. | ||
| */ | ||
| public function setToResponse(ResponseInterface $response): ResponseInterface |
There was a problem hiding this comment.
Suggested change
| public function setToResponse(ResponseInterface $response): ResponseInterface | |
| public function addToResponse(ResponseInterface $response): ResponseInterface |
That's how it's usually named.
src/ErrorData.php
Outdated
| use Psr\Http\Message\ResponseInterface; | ||
|
|
||
| /** | ||
| * ErrorData stores content and headers that are suitable for displaying. |
There was a problem hiding this comment.
Suggested change
| * ErrorData stores content and headers that are suitable for displaying. | |
| * ErrorData stores content and headers that are suitable for adding to response. |
src/ErrorData.php
Outdated
| private string $content; | ||
|
|
||
| /** | ||
| * @var array<string, string|string[]> The headers of error data to add to the response. |
There was a problem hiding this comment.
Suggested change
| * @var array<string, string|string[]> The headers of error data to add to the response. | |
| * @var array<string, string|string[]> The headers to add to the response. |
src/ErrorData.php
Outdated
Comment on lines
14
to
17
| /** | ||
| * @var string The content of error data. | ||
| */ | ||
| private string $content; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var string The content of error data. | |
| */ | |
| private string $content; | |
| /** | |
| * @var string The content to use as response body. | |
| */ | |
| private string $content; |
src/ErrorData.php
Outdated
Comment on lines
25
to
26
| * @param string $content The content of error data. | ||
| * @param array<string, string|string[]> $headers The headers of error data to add to the response. |
There was a problem hiding this comment.
Suggested change
| * @param string $content The content of error data. | |
| * @param array<string, string|string[]> $headers The headers of error data to add to the response. | |
| * @param string $content The content to use as response body. | |
| * @param array<string, string|string[]> $headers The headers to add to the response. |
src/Middleware/ErrorCatcher.php
Outdated
| return $new; | ||
| } | ||
|
|
||
| /** | ||
| * @param string[] $mimeTypes MIME types or, if not specified, all will be removed. | ||
| * @param string[] $contentTypes MIME types or, if not specified, all will be removed. |
There was a problem hiding this comment.
Suggested change
| * @param string[] $contentTypes MIME types or, if not specified, all will be removed. | |
| * @param string[] $contentTypes MIME types to remove associated renderers for. If not specified, all renderers will be removed. |
src/ThrowableRendererInterface.php
Outdated
| @@ -8,27 +8,29 @@ | |||
| use Throwable; | |||
|
|
|||
| /** | |||
| * ThrowableRendererInterface converts throwable into its string representation | |||
| * ThrowableRendererInterface converts throwable into error data suitable for displaying. | |||
There was a problem hiding this comment.
Suggested change
| * ThrowableRendererInterface converts throwable into error data suitable for displaying. | |
| * ThrowableRendererInterface converts throwable into error data suitable for adding it to response. |
samdark
added
status:under development
devanych
added
status:code review
samdark
approved these changes
Feb 20, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.