Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required aria attribute #68

Merged
merged 27 commits into from Jan 24, 2021
Merged

Required aria attribute #68

merged 27 commits into from Jan 24, 2021

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Jan 8, 2021

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️
Analogue for #66
Depends on #67, yiisoft/validator#96

@xepozz xepozz added the status:code review The pull request needs review. label Jan 8, 2021
@xepozz xepozz requested a review from a team January 8, 2021 14:32
@xepozz xepozz changed the base branch from master to html-like-rules January 23, 2021 16:55
src/HtmlOptions/ValidatorAwareTrait.php Outdated Show resolved Hide resolved
src/FormModel.php Show resolved Hide resolved
src/HtmlOptions/RequiredHtmlOptions.php Show resolved Hide resolved
# Conflicts:
#	src/HtmlOptions/EmailHtmlOptions.php
#	src/HtmlOptions/HasLengthHtmlOptions.php
#	src/HtmlOptions/MatchRegularExpressionHtmlOptions.php
#	src/HtmlOptions/NumberHtmlOptions.php
#	src/HtmlOptions/RequiredHtmlOptions.php
@samdark samdark changed the base branch from html-like-rules to master January 24, 2021 19:42
# Conflicts:
#	src/FormModel.php
#	tests/Stub/PersonalForm.php
@samdark samdark merged commit c6ccf9d into master Jan 24, 2021
@samdark samdark deleted the required-aria-attribute branch January 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants