Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encode methods for different contexts #31

Merged
merged 12 commits into from Oct 31, 2020
Merged

Add encode methods for different contexts #31

merged 12 commits into from Oct 31, 2020

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 22, 2020 •
edited

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #26

Added methods:

  • encodeAttribute
  • encodeQuotedAttribute
  • escapeJsStringValue

Modify methods:

  • encode

Removed methods:

  • decode

@vjik vjik marked this pull request as ready for review October 23, 2020 20:23
@vjik vjik requested a review from a team October 23, 2020 20:23
@vjik vjik added the status:code review The pull request needs review. label Oct 23, 2020
samdark
samdark reviewed Oct 30, 2020
View reviewed changes
src/Html.php Outdated Show resolved Hide resolved
src/Html.php Outdated Show resolved Hide resolved
@samdark samdark merged commit dc58e6d into yiisoft:master Oct 31, 2020
@samdark
Copy link
Member

samdark commented Oct 31, 2020

👍

@vjik vjik deleted the encode branch November 17, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjik @samdark