Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route override #92

Merged
merged 2 commits into from Dec 28, 2020
Merged

Add route override #92

merged 2 commits into from Dec 28, 2020

Conversation

yiiliveext
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️

@yiiliveext yiiliveext requested a review from a team December 28, 2020 16:28
@samdark samdark added the status:code review The pull request needs review. label Dec 28, 2020
@roxblnfk
Copy link
Member

I would expect an exception to be thrown when defining routes of the same name.
Maybe we need to make it customizable?

@samdark samdark merged commit 374c5c8 into yiisoft:master Dec 28, 2020
@samdark
Copy link
Member

samdark commented Dec 28, 2020

👍

@yiiliveext yiiliveext deleted the fix-rc branch December 29, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yiiliveext @roxblnfk @samdark