Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first look on refactoring #1

Merged
merged 7 commits into from Nov 15, 2020
Merged

first look on refactoring #1

merged 7 commits into from Nov 15, 2020

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Nov 4, 2020

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues

@samdark samdark added the status:code review The pull request needs review. label Nov 6, 2020
@samdark samdark requested a review from a team November 6, 2020 22:26
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but please fix minor issues.

src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
src/MessageSource.php Outdated Show resolved Hide resolved
@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Nov 13, 2020
@samdark samdark requested a review from a team November 13, 2020 21:31
@samdark samdark added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Nov 15, 2020
@samdark samdark merged commit d59ee0a into yiisoft:master Nov 15, 2020
@samdark
Copy link
Member

samdark commented Nov 15, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants