Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelined cycle schema reading #68

Merged
merged 9 commits into from Nov 13, 2020

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Oct 22, 2020

Q A
New feature? ✔️
Breaks BC?

SchemaProviderInterface now contains only read and clear schema related methods, and read() method changed to read(?SchemaProviderInterface $nextProvider = null).
SchemaManager is deprecated (should be removed later).

Now there is no need to force to write the schema from the outside. Each provider can decide this on their own.
It also allows the provider to change the schema he received from the $nextProvider.

@roxblnfk roxblnfk force-pushed the feature/read-schema-as-pipeline branch from 9a6bc5c to 84b2b4b Compare November 9, 2020 13:44
@roxblnfk roxblnfk requested review from samdark, thenotsoft and a team November 9, 2020 17:54
@roxblnfk roxblnfk marked this pull request as ready for review November 9, 2020 17:54
@roxblnfk roxblnfk force-pushed the feature/read-schema-as-pipeline branch from 83fb730 to 67264d9 Compare November 10, 2020 13:57
Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
@samdark samdark added the status:code review The pull request needs review. label Nov 12, 2020
@samdark
Copy link
Member

samdark commented Nov 13, 2020

@roxblnfk feel free to merge it when ready.

@samdark samdark merged commit c69dbef into yiisoft:master Nov 13, 2020
@samdark
Copy link
Member

samdark commented Nov 13, 2020

👍

@roxblnfk roxblnfk deleted the feature/read-schema-as-pipeline branch November 13, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants