Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 404 fallback page #203

Merged
merged 2 commits into from Dec 16, 2020
Merged

Added 404 fallback page #203

merged 2 commits into from Dec 16, 2020

Conversation

1Luc1
Copy link
Contributor

@1Luc1 1Luc1 commented Dec 16, 2020

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #192

no cats, sry 😸

Mister-42
Mister-42 reviewed Dec 16, 2020
View reviewed changes
views/site/404.php Outdated Show resolved Hide resolved
@samdark samdark added the status:code review The pull request needs review. label Dec 16, 2020
@samdark samdark modified the milestone: 3.0.0-alpha1 Dec 16, 2020
@1Luc1
removed url param to view
3fa55e7 
added urlMather usage in view
@Mister-42
Copy link
Contributor

Mister-42 commented Dec 16, 2020 •
edited

Hard way to learn $urlMatcher->getCurrentRoute() will be NULL. Makes sense, but something to be aware of when used somewhere.

PR looks good!

@samdark samdark merged commit 8adf29f into yiisoft:master Dec 16, 2020
@samdark
Copy link
Member

samdark commented Dec 16, 2020

Thanks.

@1Luc1 1Luc1 deleted the 404-fallback-page branch December 25, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-42 Mister-42 Mister-42 left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1Luc1 @Mister-42 @samdark