Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci-oracle and fixed tests fails. #18385

Merged
merged 56 commits into from Nov 23, 2020
Merged

Add ci-oracle and fixed tests fails. #18385

merged 56 commits into from Nov 23, 2020

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

@terabytesoftw
Add github actions oracle.
0460bf9
@terabytesoftw
Fix name workflow.
8be1277
@terabytesoftw
Fix workflow ci-oracle.yml.
5cd325c
@terabytesoftw
Fix workflow again.
d2d254c
@terabytesoftw
Add extension oci8.
c51f647
@terabytesoftw
Fix CommandTest::testQueryCache.
ae68e63
@terabytesoftw
Fix tests CommandTest::testBindParamsNonWhere.
615fe0e
@terabytesoftw
Fix test CommandTest::testInsert.
41d0fbb
@terabytesoftw
Fix test CommanTest::testInsertExpression.
8950ad7
@terabytesoftw
Fix test CommandTest::testInsertSelectAlias.
fc9ede6
@terabytesoftw
Fix test CommandTest::testBindParamValue.
5a67289
@terabytesoftw
Remove type php 5.4, 5.5.
8e0250e
@terabytesoftw
Fix tests CommandTest::testBatchInsertDataTypesLocale.
6f12188
@terabytesoftw
Fix test CommandTest::testNoTablenameReplacement.
3db5da6
@terabytesoftw
Fix test CommandTest::testCreateTable.
6429c3a
@terabytesoftw
Fix test CommandTest::testsInsertQueryAsColumnValue.
347c388
@terabytesoftw
Fix tests CommandTest::testAlterTable.
d5b77db
@terabytesoftw
Fix test CommandTest::testCreateView.
f652395
@terabytesoftw
Fix test CommandTest::testTransaction.
f1fa1fb
@terabytesoftw
Fix test ConnectionTest::testTransactionShortcutCorrect.
f3866b2
@terabytesoftw
Fix test ConnectionTest::testTransactionShortcutCustom.
5ae7555
@terabytesoftw
Fix test ConnectionTest::testEnableQueryLog.
5bd985d
@terabytesoftw
Fix test QueryBuilder::testAddDropDefaultValue.
26b9cdd
@terabytesoftw
Fix test QueryTest::testUnion.
4fa07d6
@terabytesoftw
Fix test QueryTest::testExpressionInFrom.
79bf506
@terabytesoftw
Fix test SchemaTest::testFindUniqueIndexes.
a17b308
@terabytesoftw
Remove typehint php 5.4, 5.5.
391171e
@terabytesoftw
Fix test QueryBuilderTest::testGetColumnType.
e71e0b7
@terabytesoftw
Fix test ActiveRecordTest::testFind.
b541a67
@terabytesoftw
Fix test ExistValidatorTest::testExpresionInAttributeColumnName.
0d42a30
@terabytesoftw terabytesoftw marked this pull request as ready for review November 16, 2020 17:20
@terabytesoftw
Copy link
Member Author

@samdark You have to check:

  • CommandTest::testColumnCase().
  • QueryBuilderTest::testAddDropDefaultValue() - 'Adding/dropping default constraints is not supported in Oracle.'.
  • QueryTest::testUnion() - 'Unsupported use of WITH clause nested in Oracle.'.
  • SchemaTest::testCompositeFk - 'Should be fixed.'.
  • QueryBuilderTest::testBuildCondition() - 'fail 3 conditions in conditionsProvider() in tests/framework/db/oci/QueryBuilderTest

@samdark samdark added this to the 2.0.40 milestone Nov 16, 2020
@samdark samdark added the Oracle label Nov 16, 2020
@samdark samdark requested a review from a team November 16, 2020 22:21
@samdark samdark added the status:code review The pull request needs review. label Nov 18, 2020
@samdark samdark merged commit 8784331 into yiisoft:master Nov 23, 2020
@samdark
Copy link
Member

samdark commented Nov 23, 2020

Thank you! That's great addition to Yii 2 stability.

@terabytesoftw terabytesoftw deleted the add-ci-oracle branch July 10, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

@bizley bizley bizley approved these changes

Assignees
No one assigned
Labels
feature:db Oracle status:code review The pull request needs review.
Projects
None yet
Milestone
2.0.40
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terabytesoftw @samdark @bizley