InitContainers should include AdditionalVolumes as well #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanchenko-igor
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
yanchenko-igor
force-pushed
the
additionalvolumes_for_initcontainers
branch
from
c83d7b6
to
ee4bb71
Compare
|
Hi, any opinion on this PR? |
yanchenko-igor
force-pushed
the
additionalvolumes_for_initcontainers
branch
from
ee4bb71
to
d58393a
Compare
yanchenko-igor
force-pushed
the
additionalvolumes_for_initcontainers
branch
from
d58393a
to
fef2d2a
Compare
|
Hm, with initContainers we already support the full And sorry, you had to wait for feedback this long. |
yanchenko-igor
force-pushed
the
additionalvolumes_for_initcontainers
branch
from
fef2d2a
to
ee2a55f
Compare
|
Hello. Init containers can help us with different maintenance tasks. You have mechanism in CRD. It would be great if this feature would be unified. |
|
@FxKu you define volumes in pod spec and reference them in initContainers, so if the podSpec does not contain "my-custom-vol", the container can not reference it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I believe that init containers should have additional volumes as well. this patch fixes the issue.